search

jbboehr / php-mustache

Mustache PHP Extension
MIT License
56 stars 22 forks source link

Build warnings #38

Closed remicollet closed 7 years ago

remicollet commented 7 years ago

Too much build warnings introduce noise which can hide serious issues. This fix all of them, even if some are mostly false-positive from the compiler.

remicollet commented 7 years ago

Of course, need to be reviewed carefully. and yes, I build everything using -Wall ;)

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 89.305% when pulling d9d5d71c7af96b3dfa6f9afec1bcaf5b955b712b on remicollet:issue-warn into e125067dd70e9358d77899068a58b63306fc34ab on jbboehr:master.

jbboehr commented 7 years ago

LGTM

remicollet commented 7 years ago

Thanks