search

jbcarpanelli / spinnies

Node.js module to create and manage multiple spinners in command-line interface programs
MIT License
147 stars 32 forks source link

disable forcing dashes on win32 #1

Closed devmondo closed 5 years ago

devmondo commented 5 years ago

Hi, really awesome spinner and options, thanks alot for it :)

but can you please disable the enforcement of dashes spinners on win32, i am using windows 10 and it is perfectly capable of showing all symbols, i tested by manually commenting the if condition and it wokred.

thanks in advace :)

jbcarpanelli commented 5 years ago

Hello, @devmondo! Thanks for raising this :muscle: . I wasn't 100% sure whether it was necessary to use a more conventional set of symbols for win32. I'm glad that it's not! I will fix it soon and release a new version afterwards. In the meantime, you can set the spinner animation manually as explained here (example included!).

devmondo commented 5 years ago

thank @jcarpanelli for the prompt reply, but unless i am doing something wrong, the override option you mention i tried but it does not seem to work!

one note, you might want to make that option, in case someone I not using the latest windows 10 :)

jbcarpanelli commented 5 years ago

Hello there, @devmondo ! I finally kept the win32 validation, but thanks to this issue I realized that it wasn't possible to override the default win32 spinner, which was a bug :bug:. I released v0.3.1 with a fix. You now should be able to override the spinner option as explained in the example mentioned in my previous answer! Both spinners are also being exported now, so you are able to do something like:

import { dots }, Spinnies from 'spinnies';

const spinnies = new Spinnies({ spinner: dots });

If you think your problem has been solved, please feel free to close this issue.

devmondo commented 5 years ago

awesome work man!!!, it works perfectly, really loves your work there :)