search

jbcarpanelli / spinnies

Node.js module to create and manage multiple spinners in command-line interface programs
MIT License
147 stars 32 forks source link

Fixed Windows default spinner and prefix #8

Closed jonbarrow closed 5 years ago

jonbarrow commented 5 years ago

Related to https://github.com/jcarpanelli/spinnies/issues/6.

On Windows the default spinner was never set to "dashes", and was always set to "dots". I assume this is a bug as there's a check for the system type and it tries to set the spinner to "dashes", but it gets overwritten. This has been fixed. Also the default command line cannot handle the current characters used for success and fail prefixes, these have been updated to check the system type (using some "close enough" characters for Windows) and allows you to set custom prefixes if needed.

jbcarpanelli commented 5 years ago

Ready to merge! thanks again for contributing!