search

jbeard4 / SCION

SCXML/Statecharts in JavaScript, moved to gitlab: https://gitlab.com/scion-scxml/scion
https://scion.scxml.io
Apache License 2.0
149 stars 29 forks source link

Scjson support #302

Closed feyzo closed 9 years ago

feyzo commented 9 years ago

PR ready. Merge with https://github.com/jbeard4/scxml-test-framework/pull/14

Currently 160 tests are passing, 55 from W3C. Closing 12 issues: 8 errors, 4 fails.

Closes #189 Closes #221 Closes #222 Closes #223 Closes #224 Closes #225 Closes #226 Closes #227 Closes #228 Closes #230 Closes #272 Closes #284

jbeard4 commented 9 years ago

The issue with #230 is that https://github.com/jbeard4/SCION/pull/302/files#diff-799c2415054a6b927e89aa940dc23420R149 is setting the value of cond to boolean false. This should be set to the string literal "false". I think #230 should work after that, without requiring changes to SCION-CORE.

While looking over this code, I found this potential issue: https://github.com/jbeard4/SCION/pull/302#discussion_r20977855

Code coverage reports can help us ensure all paths in our code are fully tested. Created a new issue for this: https://github.com/jbeard4/SCION/issues/312

jbeard4 commented 9 years ago

Why is this PR merging into branch issue-233, rather than branch 2.0.0-w3c-ecma?

feyzo commented 9 years ago

PR is merging into issue-233 because it has file inliner.

jbeard4 commented 9 years ago

Can you please prep this to merge with 2.0.0-w3c-ecma?