search

jbeder / yaml-cpp

A YAML parser and emitter in C++
MIT License
5.09k stars 1.83k forks source link

Test(Node): (const)iterator on sequence #1169

Closed MatthijsBurgh closed 1 year ago

MatthijsBurgh commented 1 year ago

This should be a valid test for the issues described in https://github.com/jbeder/yaml-cpp/issues/833.

So these tests should fail. Otherwise these test are not valid or there is a different in how the tests are build versus how users build against this library.

MatthijsBurgh commented 1 year ago

The test don't seem to be run in GH actions. See https://github.com/jbeder/yaml-cpp/pull/1170 for that one. CI run on my fork: https://github.com/MatthijsBurgh/yaml-cpp/actions/runs/4074000407

Though that one show the added tests don't fail, which means we haven't found a way yet to reproduce the issue of #833 in a clean environment.

MatthijsBurgh commented 1 year ago

Although this test doesn't exposes the issue of #833, this is still a good addition to the tests.

MatthijsBurgh commented 1 year ago

Ping @jbeder