Don't install embedded copy of GTest

jbeder / yaml-cpp

A YAML parser and emitter in C++

MIT License

4.92k stars 1.78k forks source link

Don't install embedded copy of GTest #1171

Open PhilMiller opened 1 year ago

PhilMiller commented 1 year ago

Google Test itself documents the INSTALL_GTEST option as something that projects embedding it should set to OFF. Leaving it on means that projects downstream from libraries that embed it are likely to encounter conflicting copies. This is particularly annoying because GTest does not maintain anything like a stable API, and so causes builds to fail if include paths pick up an inappropriately installed copy ahead of the one that the code wanted.

Fixes #488

nigels-com commented 2 months ago

Looks good.

ahogen commented 5 days ago

Related, but maybe out of scope for this MR -- this project's documentation generator is recursing into the GoogleTest directories and publishing its docs. Things like GoogleTest's own "how to contribute" type docs are being shown in this project. Took me a sec to realize what was going on. Rather confusing.

https://codedocs.xyz/jbeder/yaml-cpp/pages.html