Open rengzhengcodes opened 1 year ago
Hello!
I believe there may be an error in how the current codebase handles true/false value resolution for YAML 1.2. The lines in question are linked below: https://github.com/jbeder/yaml-cpp/blob/0e6e28d1a38224fc8172fae0109ea7f673c096db/src/convert.cpp#L49-L55
According to this section of the YAML 1.2 guide: https://yaml.org/spec/1.2-old/spec.html#id2805071
Only variants on "true"/"false" in the YAML file should resolve to the booleans. However, the above-linked code also resolves three other ways to represent booleans outside of 1.2 specs but was present in 1.1 specs.
Yep, fair; will accept a PR.
jbeder
commented
5 months ago
Hello!
I believe there may be an error in how the current codebase handles true/false value resolution for YAML 1.2. The lines in question are linked below: https://github.com/jbeder/yaml-cpp/blob/0e6e28d1a38224fc8172fae0109ea7f673c096db/src/convert.cpp#L49-L55
According to this section of the YAML 1.2 guide: https://yaml.org/spec/1.2-old/spec.html#id2805071
Only variants on "true"/"false" in the YAML file should resolve to the booleans. However, the above-linked code also resolves three other ways to represent booleans outside of 1.2 specs but was present in 1.1 specs.