Newest version doesn't build anymore

lukas-wresch commented 9 months ago

Today I am getting the following error when running make.

[  2%] Building CXX object CMakeFiles/yaml-cpp.dir/src/convert.cpp.o
In file included from /home/git/actions-runner/_work/dep/yaml-cpp/src/convert.cpp:3:
/home/git/actions-runner/_work/dep/yaml-cpp/include/yaml-cpp/node/convert.h:20:10: fatal error: version: No such file or directory
 #include <version>
          ^~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/yaml-cpp.dir/build.make:102: CMakeFiles/yaml-cpp.dir/src/convert.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:912: CMakeFiles/yaml-cpp.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

I believe this is due to commit 6262201182a0ee357d8a456e6d1a8e5984e4c6dd

lukas-wresch commented 9 months ago

__cpp_lib_string_view requires <version> which in turn seems to require C++ 20. This seems to defeat the purpose of PR #1222

jbeder commented 9 months ago

Interesting. What version compiler are you running?

lukas-wresch commented 9 months ago

I am still forced to use gcc 8.3.0

tchaikov commented 9 months ago

@lukas-wresch hi Lukas, sorry for the regression. should be fixed by #1225.

lukas-wresch commented 9 months ago

tchaikov Thank you! I can confirm that this issue is fixed by PR #1225

jbeder / yaml-cpp

Newest version doesn't build anymore #1223