jbeder / yaml-cpp

A YAML parser and emitter in C++
MIT License
4.91k stars 1.77k forks source link

Add missing iostream header #1283

Open rurban opened 1 month ago

jbeder commented 1 month ago

Why?

rurban commented 1 month ago

Try with gcc 14

Jesse Beder @.***> schrieb am Mo., 27. Mai 2024, 16:33:

Why?

— Reply to this email directly, view it on GitHub https://github.com/jbeder/yaml-cpp/pull/1283#issuecomment-2133478712, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAKGUKKEFYIIXKD75S26O3ZEMXTHAVCNFSM6AAAAABIK4L4SCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTGQ3TQNZRGI . You are receiving this because you authored the thread.Message ID: @.***>

jbeder commented 1 month ago

It's customary to do things like post the exact error message.

rurban commented 3 weeks ago

Ok, this has to be reworked. It fails on my ubuntu 24.04 clang-tidy with missing iostream:

/usr/local/include/yaml-cpp/parser.h:10:10: error: 'iostream' file not found [clang-diagnostic-error]
   10 | #include <iostream>

but my fedora core 40 with gcc 14 warns about a missing iostream header. will check there