search

jbeder / yaml-cpp

A YAML parser and emitter in C++
MIT License
5.18k stars 1.87k forks source link

Stomping on build flags #634

Open joelfrederico opened 6 years ago

joelfrederico commented 6 years ago

https://github.com/jbeder/yaml-cpp/blob/774f25800e6f19f4b927023c85d1389af322da5e/CMakeLists.txt#L144-L147

https://github.com/jbeder/yaml-cpp/blob/774f25800e6f19f4b927023c85d1389af322da5e/CMakeLists.txt#L161-L164

There is a Clang compiler for Windows, and stomping on the existing flags is not a good idea anyways. Why not just leave the flags alone? CMake has sensible defaults and people can override them if they want to.

joelfrederico commented 6 years ago

See https://github.com/jbeder/yaml-cpp/pull/635