jbeder / yaml-cpp

A YAML parser and emitter in C++
MIT License
5.04k stars 1.81k forks source link

Comment after literal string #800

Open vokimon opened 4 years ago

vokimon commented 4 years ago

By running this code:

#include <yaml-cpp/yaml.h>
#include <iostream>
#include <fstream>

int main() {
    {
        std::ofstream f("hola.yaml");
        YAML::Emitter emitter(f);
        emitter << YAML::Literal << "Hello\nworld" << YAML::Comment("Un comentario");
    }
    {
        std::ifstream f("hola.yaml");
        YAML::Node node = YAML::Load(f);
        std::cout << node.as<std::string>() << std::endl;
    }
    return 0;
}

The first part generates the following content:

|
  Hello
  world # A comment

When the second part reads it back, the comment is read as part of the literal. One of them, reading or writing is wrong. Specs says that no comments can be placed inside an scalar, since a literal is an scalar and it terminates with the indentation back, it sounds like the reading is right and the writing is wrong.

When a scalar is inserted in literal mode comments inserted next should be at the next line. and outside of the indentation. Like this:

|
  Hello
  world
# A comment
vokimon commented 4 years ago

Work arround: inserting a Newline after the literal. Caution: this is parsed as having an endline at the end of the string ("Hello\nworld\n") instead of the inserted ("Hello\nworld"). It is better than having the comment included in the literal ("Hello\nworld # Un comentario") but stil write/read is not idempotent.

    {
        std::ofstream f("hola.yaml");
        YAML::Emitter emitter(f);
        emitter
            << YAML::Literal << "Hello\nworld"
            << YAML::Newline << YAML::Comment("Un comentario")
            ;
    }