I implemented your suggestions from #64. I also took the liberty to change the image icon, add a screenshot icon and toggle dark background"-icon. If you don't agree with this choice, no problem.
The pull request is marked WIP because of one issue: I tried making the binary independent of location, to fix #28 based on this comment. I did this by using the cmake variable ASSETS_PATH, and loading the assets by converting this macro into filepaths in Mainframe.cpp.
This fixed #28, but labels are still not loaded when the GUI is started from anywhere outside point_labeler/bin. According to my debugger, the label files paths are correctly loaded, yet the labels are not shown and the scans remain colored gray. Is this issue worth fixing, and/or where do you think additional changes need to be made to load the labels?
Lastly, where did you get your icons from? I obeyed the license, and gave attribution to the authors, as seen at the end of the README
I implemented your suggestions from #64. I also took the liberty to change the image icon, add a screenshot icon and toggle dark background"-icon. If you don't agree with this choice, no problem.
The pull request is marked WIP because of one issue: I tried making the binary independent of location, to fix #28 based on this comment. I did this by using the cmake variable
ASSETS_PATH, and loading the assets by converting this macro into filepaths inMainframe.cpp.This fixed #28, but labels are still not loaded when the GUI is started from anywhere outside
point_labeler/bin. According to my debugger, the label files paths are correctly loaded, yet the labels are not shown and the scans remain colored gray. Is this issue worth fixing, and/or where do you think additional changes need to be made to load the labels?Lastly, where did you get your icons from? I obeyed the license, and gave attribution to the authors, as seen at the end of the README