jbenden / vscode-c-cpp-flylint

A VS Code extension for advanced, modern, static analysis of C/C++ that supports a number of back-end analyzer programs.
MIT License
152 stars 29 forks source link

extract system path helper fn #183

Closed jbenden closed 1 year ago

jbenden commented 1 year ago

Extracts a helper function to deal with system paths; namely for Windows OS handling.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3862858651


Changes Missing Coverage Covered Lines Changed/Added Lines %
server/src/linters/clang.ts 2 3 66.67%
server/src/linters/linter.ts 1 2 50.0%
server/src/utils.ts 12 13 92.31%
server/src/server.ts 2 27 7.41%
<!-- Total: 27 55 49.09% -->
Files with Coverage Reduction New Missed Lines %
server/src/server.ts 4 10.61%
server/src/utils.ts 4 75.0%
<!-- Total: 8 -->
Totals Coverage Status
Change from base Build 3509173851: 1.2%
Covered Lines: 458
Relevant Lines: 823

💛 - Coveralls
dzid26 commented 1 year ago

All tools run ok for me now. Squiggles not showing as before.

jbenden commented 1 year ago

@dzid26 Do the error squiggles now appear?

dzid26 commented 1 year ago

Oh, I forgot to test earlier. Unfortunately, squiggles still don't appear.

I wanted to investigate a bit, but couldn't bind breakpoints for some reason.

jbenden commented 1 year ago

Hi, I'll have to build a test VM running Windows, then. What clang/cppcheck/etc are you using? Is it choco or?

dzid26 commented 1 year ago

Those:

jbenden commented 1 year ago

Hi, I believe the squiggles problem to now be fixed. At least very hopeful! :)

FYI: The unit-tests fail to work at all on Windows; but others are complaining. Maybe it'll be resolved at some point. The unit-tests do not even get a chance to run, it fails within early git/github extensions bundled with VSCode.

Thanks, -Joe

dzid26 commented 1 year ago

It worked this time. Great!