jbenet / depviz

dependency visualizer for the web
https://jbenet.github.io/depviz
MIT License
49 stars 10 forks source link

Navigation not working fully #31

Closed victorb closed 7 years ago

victorb commented 7 years ago

Let's say I load ipld/website in depviz.

https://jbenet.github.io/depviz/#/http/github.com/ipld/website

I then use the "address bar" in the top right to change to github.com/jbenet/depviz and presses enter/click on "Go"

Nothing happens. However, if I reload the page after pressing enter, it loads the right page.

Something tells me the history haven't been implemented correctly since the back button doesn't either change to the right page.


depends on #32

wking commented 7 years ago

This may have something to do with hashHistory, because the jump bar is just using router.push. Using HTML5 history would be nicer, but it needs redirects that gh-pages doesn't provide without some ugly gymnastics.