jbenet / depviz

dependency visualizer for the web
https://jbenet.github.io/depviz
MIT License
49 stars 10 forks source link

Add a status checkbox to displayed cards #39

Closed wking closed 7 years ago

wking commented 7 years ago

GitHub doesn't seem to expose this on issue results, but we can use the API here. For example:

$ curl https://api.github.com/repos/jbenet/depviz/commits/refs/pull/35/head/status
{
  "state": "success",
  "statuses": [
    {
      "url": "https://api.github.com/repos/jbenet/depviz/statuses/7f5536da1cddd9010dcac3f62afc12f5110cab6d",
      "id": 888186845,
      "state": "success",
      "description": "The Travis CI build passed",
      "target_url": "https://travis-ci.org/jbenet/depviz/builds/180569146",
      "context": "continuous-integration/travis-ci/pr",
      "created_at": "2016-12-01T23:49:38Z",
      "updated_at": "2016-12-01T23:49:38Z"
    }
  ],
  "sha": "7f5536da1cddd9010dcac3f62afc12f5110cab6d",
  …
}

depends on #69

jbenet commented 7 years ago

Oh, nice! yeah!

wking commented 7 years ago

Trying to come up with a display for this, I think we may want to drop our current right column:

current

to be a fourth row:

bottom-row

That gives us more space for multiple people and longer IDs/titles, keeps the cards at a reasonable size, and doesn't crowd too much. The CI-status icon is in the lower right, and I was thinking of icons like:

The in-progress U+25CF is a bit heavy in black, but would probably feel more appropriately sized in amber.

Does anything in there sound good? Do folks have other ideas for how CI-status should look?

wking commented 7 years ago

I'm just going to go ahead with the design floated above^. We can always adjust later if folks want to shuffle the card contents.