webapp/src/Graph.js: O(n²) → O(n) search for edges

jbenet / depviz

dependency visualizer for the web

https://jbenet.github.io/depviz

MIT License

49 stars 10 forks source link

webapp/src/Graph.js: O(n²) → O(n) search for edges #52

Closed wking closed 7 years ago

wking commented 7 years ago

We don't have to visit all node-node pairs, because we wrote the dot source ourselves and only added edges for parents. We'll need to update this to also include related-issue edges once we add support for related issues, but for the 500-odd issues in github.com/ipfs/go-ipfs this shaves a second or so off the positioning time.

Also includes a drive-by commit to bail out of positioning early if we have no nodes to position.

wking commented 7 years ago

Pushed an indexing bugfix with 5a3b0b9 → 14a275f which should green up Travis.

jbenet commented 7 years ago

👍