search

jbenet / depviz

dependency visualizer for the web
https://jbenet.github.io/depviz
MIT License
49 stars 10 forks source link

DepIndicators: Click on DependenciesIndicator to load dependencies #64

Closed wking closed 7 years ago

wking commented 7 years ago

We currently don't walk dependencies for closed issues, because they're not related to future progress. However, the completed-issue graph is useful for historical context, and @jbenet is interested in walking that graph.

To make this straightforward, we probably want a way to configure a hop-depth from a current node. But the current UI lacks a “current node” concept and we haven't settled on a UI for selecting nodes (#30, #45). In the meantime, this patch gives users a way for users to drill down into the dependencies of any closed issue by clicking on its dependencies indicator.

unwalkedDependencies is currently a bit sloppy, since it should be false if all of the parents have already been walked. The current implementation is good enough for a first pass though.

wking commented 7 years ago

Merged my own PR (over a week without negative reviews).