jbenet / depviz

dependency visualizer for the web
https://jbenet.github.io/depviz
MIT License
49 stars 10 forks source link

DepCard: Display status icon (e.g. for continuous integration tests) #69

Closed wking closed 7 years ago

wking commented 7 years ago

Using a separate call to the GitHub API for open pull requests, because GitHub doesn't expose this information directly in its issue response. The hack access to _request works around the currently-missing github-tools/github wrapper for this API endpoint.

We don't look this up for closed pull requests, because a separate per-issue request is expensive, and users are unlikely to care that much about the CI status of closed pull requests. If it turns out that some do care, we'll have to make the done-ness filter configurable.

This commit also shuffles the expanded card from a two-column, three-line layout to a one-column, four-line layout (although the last line is split into a number of columns). That gives us more space for multiple people and longer IDs/titles, keeps the cards at a reasonable size, and doesn't crowd too much.

Fixes #39.

wking commented 7 years ago

Screenshots:

success

pending