search

jberet / jsr352

Implementation of Jakarta Batch Specification and API
Eclipse Public License 2.0
125 stars 76 forks source link

Job versioning does not appear to be supported in JBeret #278

Open idursto opened 1 year ago

idursto commented 1 year ago

Somewhat new to JBeret and JSR-352, but after setting things up and debugging it does not appear the version columns are populated based on what you have set within your job...

My Example job:

<job id="test" restartable="#{jobParameters['restartable']}?:true" xmlns="http://xmlns.jcp.org/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/jobXML_1_0.xsd" version="1.0"> ... etc ...

And the JdbcRepository inserts I debugged down to:

https://github.com/jberet/jsr352/blob/77be854de4839c89e53b28d5229d58a9097ba97b/jberet-core/src/main/java/org/jberet/repository/JdbcRepository.java#L322

https://github.com/jberet/jsr352/blob/77be854de4839c89e53b28d5229d58a9097ba97b/jberet-core/src/main/java/org/jberet/repository/JdbcRepository.java#L448

Am I missing something in my settup or is this just something that is not in scope of what is supported within JBeret? I dont feel like it would be too difficult to persist the version from the Job XML down the repository would it?

Any help is appreciated...

chengfang commented 1 year ago

version can be safely ignored. Initially it was intended to track different versions of job data, but is not implemented.