search

jberet / jsr352

Implementation of Jakarta Batch Specification and API
Eclipse Public License 2.0
126 stars 76 forks source link

add feature-pack module and relative tests. #418

Closed liweinan closed 11 months ago

liweinan commented 11 months ago

@jamezp Thanks for teaching! I'll do the modifications according to your review :D

btw, is there anyway in wildfly-maven-plugin that can do the configuration to override the feature-pack version directly?

jamezp commented 11 months ago

@jamezp Thanks for teaching! I'll do the modifications according to your review :D

btw, is there anyway in wildfly-maven-plugin that can do the configuration to override the feature-pack version directly?

No. Galleon does not allow overriding versions to my knowledge. It's supposed to be possible with channels, but I don't really know enough about them on how to make them work.

liweinan commented 11 months ago

After some modifications now the error is:

 mvn clean wildfly:package                                                                                                                                                                                                                                                                 01:16:49
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------< org.jberet.test:test-deployment >-------------------
[INFO] Building test-deployment 2.1.4-SNAPSHOT
[INFO] --------------------------------[ war ]---------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:3.3.2:clean (default-clean) @ test-deployment ---
[INFO] Deleting /Users/weli/works/jsr352/test-deployment/target
[INFO] 
[INFO] --- wildfly-maven-plugin:4.2.1.Final:package (default-cli) @ test-deployment ---
[INFO] Provisioning server in /Users/weli/works/jsr352/test-deployment/target/test-server/wildfly-30.0.0.Final
[INFO] Resolving feature-packs
[INFO] Installing packages
[INFO] Resolving artifacts
[INFO] Generating configurations
12月 06, 2023 1:21:05 上午 org.wildfly.core.embedded.LoggerContext$JBossLoggingModuleLogger greeting
INFO: JBoss Modules version 2.1.2.Final
12月 06, 2023 1:21:06 上午 org.jboss.msc.service.ServiceContainerImpl <clinit>
INFO: JBoss MSC version 1.5.2.Final
12月 06, 2023 1:21:06 上午 org.jboss.threads.Version <clinit>
INFO: JBoss Threads version 2.4.0.Final
12月 06, 2023 1:21:06 上午 org.jboss.as.server.ApplicationServerService start
INFO: WFLYSRV0049: WildFly EE 30.0.0.Final (WildFly Core 22.0.1.Final) starting
12月 06, 2023 1:21:06 上午 org.jboss.as.server.suspend.SuspendController resume
INFO: WFLYSRV0212: Resuming server
12月 06, 2023 1:21:06 上午 org.jboss.as.server.BootstrapListener printBootStatisticsMessage
INFO: WFLYSRV0025: WildFly EE 30.0.0.Final (WildFly Core 22.0.1.Final) started in 638ms - Started 28 of 31 services (3 services are lazy, passive or on-demand) - Server configuration file in use: standalone.xml
12月 06, 2023 1:21:07 上午 org.wildfly.security.Version <clinit>
INFO: ELY00001: WildFly Elytron version 2.2.2.Final
12月 06, 2023 1:21:07 上午 org.jboss.as.controller.AbstractOperationContext executeStep
ERROR: WFLYCTL0013: Operation ("add") failed - address: ([("extension" => "org.wildfly.extension.batch.jberet")])
java.lang.NoClassDefFoundError: org/jberet/spi/JobExecutor
        at org.wildfly.extension.batch.jberet@30.0.0.Final//org.wildfly.extension.batch.jberet._private.Capabilities.<clinit>(Capabilities.java:44)
        at org.wildfly.extension.batch.jberet@30.0.0.Final//org.wildfly.extension.batch.jberet.BatchSubsystemDefinition.<clinit>(BatchSubsystemDefinition.java:69)
        at org.wildfly.extension.batch.jberet@30.0.0.Final//org.wildfly.extension.batch.jberet.BatchSubsystemExtension.initialize(BatchSubsystemExtension.java:38)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.extension.ExtensionAddHandler.initializeExtension(ExtensionAddHandler.java:117)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.extension.ExtensionAddHandler.execute(ExtensionAddHandler.java:68)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:1048)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:769)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:460)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1433)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:432)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerImpl.lambda$executeForResponse$0(ModelControllerImpl.java:242)
        at org.wildfly.security.elytron-base@2.2.2.Final//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:304)
        at org.wildfly.security.elytron-base@2.2.2.Final//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:270)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerImpl.executeForResponse(ModelControllerImpl.java:242)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerImpl.executeOperation(ModelControllerImpl.java:236)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerClientFactoryImpl$LocalClient.executeInModelControllerCl(ModelControllerClientFactoryImpl.java:264)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerClientFactoryImpl$LocalClient$1.run(ModelControllerClientFactoryImpl.java:157)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerClientFactoryImpl$LocalClient$1.run(ModelControllerClientFactoryImpl.java:152)
        at org.wildfly.security.elytron-base@2.2.2.Final//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:304)
        at org.wildfly.security.elytron-base@2.2.2.Final//org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:270)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:181)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:158)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerClientFactoryImpl$LocalClient.executeOperation(ModelControllerClientFactoryImpl.java:152)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerClientFactoryImpl.lambda$executeInVm$0(ModelControllerClientFactoryImpl.java:356)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.access.InVmAccess.runInVm(InVmAccess.java:72)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerClientFactoryImpl.executeInVm(ModelControllerClientFactoryImpl.java:356)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.ModelControllerClientFactoryImpl$1.executeOperation(ModelControllerClientFactoryImpl.java:83)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.LocalModelControllerClient.execute(LocalModelControllerClient.java:43)
        at org.jboss.as.controller@22.0.1.Final//org.jboss.as.controller.LocalModelControllerClient.execute(LocalModelControllerClient.java:28)
        at org.jboss.as.controller.client.helpers.DelegatingModelControllerClient.execute(DelegatingModelControllerClient.java:69)
        at org.wildfly.galleon.plugin.config.generator.BaseConfigGenerator.doHandle(BaseConfigGenerator.java:78)
        at org.wildfly.galleon.plugin.config.generator.BaseConfigGenerator.endBatch(BaseConfigGenerator.java:162)
        at org.wildfly.galleon.plugin.config.generator.WfProvisionedConfigHandler.endBatch(WfProvisionedConfigHandler.java:535)
        at org.jboss.galleon.runtime.ResolvedConfig.handle(ResolvedConfig.java:147)
        at org.wildfly.galleon.plugin.config.generator.WfConfigGenerator.doGenerate(WfConfigGenerator.java:164)
        at org.wildfly.galleon.plugin.config.generator.WfConfigGenerator.generate(WfConfigGenerator.java:121)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.wildfly.galleon.plugin.WfInstallPlugin.generateConfigs(WfInstallPlugin.java:769)
        at org.wildfly.galleon.plugin.WfInstallPlugin.postInstall(WfInstallPlugin.java:437)
        at org.jboss.galleon.runtime.ProvisioningRuntime$3.visitPlugin(ProvisioningRuntime.java:269)
        at org.jboss.galleon.runtime.ProvisioningRuntime$3.visitPlugin(ProvisioningRuntime.java:266)
        at org.jboss.galleon.layout.ProvisioningLayout$Handle.visitPlugins(ProvisioningLayout.java:287)
        at org.jboss.galleon.layout.ProvisioningLayout.visitPlugins(ProvisioningLayout.java:860)
        at org.jboss.galleon.runtime.ProvisioningRuntime.provision(ProvisioningRuntime.java:266)
        at org.jboss.galleon.ProvisioningManager.doProvision(ProvisioningManager.java:650)
        at org.jboss.galleon.ProvisioningManager.provision(ProvisioningManager.java:409)
        at org.jboss.galleon.ProvisioningManager.provision(ProvisioningManager.java:397)
        at org.wildfly.plugin.provision.AbstractProvisionServerMojo.provisionServer(AbstractProvisionServerMojo.java:318)
        at org.wildfly.plugin.provision.AbstractProvisionServerMojo.execute(AbstractProvisionServerMojo.java:259)
        at org.wildfly.plugin.provision.PackageServerMojo.execute(PackageServerMojo.java:196)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
        at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:972)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:293)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:196)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
        at java.base/java.lang.reflect.Method.invoke(Method.java:580)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:282)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:225)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:406)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:347)
Caused by: java.lang.ClassNotFoundException: org.jberet.spi.JobExecutor from [Module "org.wildfly.extension.batch.jberet" version 30.0.0.Final from local module loader @1d3d76b4 (finder: local module finder @6f986501 (roots: /Users/weli/works/jsr352/test-deployment/target/test-server/wildfly-30.0.0.Final/modules,/Users/weli/works/jsr352/test-deployment/target/test-server/wildfly-30.0.0.Final/modules/system/layers/base))]
        at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:200)
        at org.jboss.modules.ConcurrentClassLoader.performLoadClassUnchecked(ConcurrentClassLoader.java:410)
        at org.jboss.modules.ConcurrentClassLoader.performLoadClass(ConcurrentClassLoader.java:398)
        at org.jboss.modules.ConcurrentClassLoader.loadClass(ConcurrentClassLoader.java:116)
        ... 71 more

12月 06, 2023 1:21:07 上午 org.jboss.as.server.ApplicationServerService stop
INFO: WFLYSRV0050: WildFly EE 30.0.0.Final (WildFly Core 22.0.1.Final) stopped in 9ms
liweinan commented 11 months ago

@jamezp Thanks for checking this!

liweinan commented 11 months ago

This is replaced by: https://github.com/jberet/jsr352/pull/427