search

jberezanski / ChocolateyPackages

Chocolatey packages maintained by me
MIT License
83 stars 51 forks source link

vcredist-all fails to install due to broken checksum of vcredist2005, vcredist2008 and vcredist2010 #105

Closed mloskot closed 3 years ago

mloskot commented 3 years ago

The choco install -y vcredist-all had been working fine (apart tiny temporary issue due to https://github.com/jberezanski/ChocolateyPackages/issues/102) and it stopped working for me around two days ago due to multiple errors like

ERROR: Checksum for 'C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2005\8.1.0.20160118\vcredist_x64.EXE'
did not meet 'ee916012783024dac67fc606457377932c826f05' for checksum type 'sha1'

Full output of the command:

> choco install -y vcredist-all
Microsoft Windows [Version 10.0.19042.867]
(c) 2020 Microsoft Corporation. All rights reserved.

C:\>powershell
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Try the new cross-platform PowerShell https://aka.ms/pscore6

PS C:\> choco
Chocolatey v0.10.15
Please run 'choco -?' or 'choco <command> -?' for help menu.
PS C:\> choco install -y vcredist-all
Chocolatey v0.10.15
Installing the following packages:
vcredist-all
By installing you accept licenses for the packages.
Progress: Downloading vcredist2005 8.1.0.20160118... 100%
Progress: Downloading vcredist-all 1.0.0... 100%
Progress: Downloading vcredist2008 9.0.30729.6163... 100%
Progress: Downloading vcredist2010 10.0.40219.325... 100%
Progress: Downloading vcredist2012 11.0.61031... 100%
Progress: Downloading vcredist2013 12.0.40660.20180427... 100%
Progress: Downloading vcredist140 14.28.29914... 100%
Progress: Downloading chocolatey-core.extension 1.3.5.1... 100%
Progress: Downloading KB3033929 1.0.5... 100%
Progress: Downloading chocolatey-windowsupdate.extension 1.0.4... 100%
Progress: Downloading KB3035131 1.0.3... 100%
Progress: Downloading KB2919355 1.0.20160915... 100%
Progress: Downloading KB2919442 1.0.20160915... 100%
Progress: Downloading KB2999226 1.0.20181019... 100%
Progress: Downloading vcredist2015 14.0.24215.20170201... 100%
Progress: Downloading vcredist2017 14.16.27033... 100%

vcredist2005 v8.1.0.20160118 [Approved]
vcredist2005 package files install completed. Performing other installation steps.
WARNING: Url has SSL/TLS available, switching to HTTPS for download
Downloading vcredist2005 64 bit
  from 'https://download.microsoft.com/download/8/B/4/8B42259F-5D70-43F4-AC2E-4B208FD8D66A/vcredist_x64.EXE'
Progress: 100% - Completed download of C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2005\8.1.0.20160118\vcredist_x64.EXE (3.03 MB).
Download of vcredist_x64.EXE (3.03 MB) completed.
Error - hashes do not match. Actual value was 'F4D74643A0E117EA80B2C7EBCD908A6DD26AA9EA'.
ERROR: Checksum for 'C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2005\8.1.0.20160118\vcredist_x64.EXE' did not meet 'ee916012783024dac67fc606457377932c826f05' for checksum type 'sha1'. Consider passing the actua
l checksums through with --checksum --checksum64 once you validate the checksums are appropriate. A less secure option is to pass --ignore-checksums if necessary.
The install of vcredist2005 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\vcredist2005\tools\chocolateyInstall.ps1'.
 See log for details.

vcredist2008 v9.0.30729.6163 [Approved]
vcredist2008 package files install completed. Performing other installation steps.
Downloading vcredist2008 64 bit
  from 'https://download.microsoft.com/download/5/D/8/5D8C65CB-C849-4025-8E95-C3966CAFD8AE/vcredist_x64.exe'
Progress: 100% - Completed download of C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2008\9.0.30729.6163\vcredist_x64.exe (4.97 MB).
Download of vcredist_x64.exe (4.97 MB) completed.
Error - hashes do not match. Actual value was 'CE8FF6572E86B0BBA39D88FA3A6D56B59100613D'.
ERROR: Checksum for 'C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2008\9.0.30729.6163\vcredist_x64.exe' did not meet 'a7c83077b8a28d409e36316d2d7321fa0ccdb7e8' for checksum type 'sha1'. Consider passing the actua
l checksums through with --checksum --checksum64 once you validate the checksums are appropriate. A less secure option is to pass --ignore-checksums if necessary.
The install of vcredist2008 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\vcredist2008\tools\chocolateyInstall.ps1'.
 See log for details.

vcredist2010 v10.0.40219.325 [Approved]
vcredist2010 package files install completed. Performing other installation steps.
Downloading vcredist2010 64 bit
  from 'https://download.microsoft.com/download/1/6/5/165255E7-1014-4D0A-B094-B6A430A6BFFC/vcredist_x64.exe'
Progress: 100% - Completed download of C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2010\10.0.40219.325\vcredist_x64.exe (9.8 MB).
Download of vcredist_x64.exe (9.8 MB) completed.
Error - hashes do not match. Actual value was 'F3B7A76D84D23F91957AA18456A14B4E90609E4CE8194C5653384ED38DADA6F3'.
ERROR: Checksum for 'C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2010\10.0.40219.325\vcredist_x64.exe' did not meet 'CC7EC044218C72A9A15FCA2363BAED8FC51095EE3B2A7593476771F9EBA3D223' for checksum type 'sha256'.
Consider passing the actual checksums through with --checksum --checksum64 once you validate the checksums are appropriate. A less secure option is to pass --ignore-checksums if necessary.
The install of vcredist2010 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\vcredist2010\tools\chocolateyInstall.ps1'.
 See log for details.

vcredist2012 v11.0.61031 [Approved]
vcredist2012 package files install completed. Performing other installation steps.
WARNING: Url has SSL/TLS available, switching to HTTPS for download
Downloading vcredist2012 64 bit
  from 'https://download.microsoft.com/download/1/6/B/16B06F60-3B20-4FF2-B699-5E9B7962F9AE/VSU_4/vcredist_x64.exe'
Progress: 100% - Completed download of C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2012\11.0.61031\vcredist_x64.exe (6.85 MB).
Download of vcredist_x64.exe (6.85 MB) completed.
Hashes match.
Installing vcredist2012...
vcredist2012 has been installed.
WARNING: Url has SSL/TLS available, switching to HTTPS for download
Downloading vcredist2012
  from 'https://download.microsoft.com/download/1/6/B/16B06F60-3B20-4FF2-B699-5E9B7962F9AE/VSU_4/vcredist_x86.exe'
Progress: 100% - Completed download of C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2012\11.0.61031\vcredist_x86.exe (6.25 MB).
Download of vcredist_x86.exe (6.25 MB) completed.
Hashes match.
Installing vcredist2012...
vcredist2012 has been installed.
  vcredist2012 may be able to be automatically uninstalled.
 The install of vcredist2012 was successful.
  Software installed as 'EXE', install location is likely default.

vcredist2013 v12.0.40660.20180427 [Approved]
vcredist2013 package files install completed. Performing other installation steps.
Downloading vcredist2013 64 bit
  from 'https://download.microsoft.com/download/0/5/6/056dcda9-d667-4e27-8001-8a0c6971d6b1/vcredist_x64.exe'
Progress: 100% - Completed download of C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2013\12.0.40660.20180427\vcredist_x64.exe (6.87 MB).
Download of vcredist_x64.exe (6.87 MB) completed.
Hashes match.
Installing vcredist2013...
vcredist2013 has been installed.
Downloading vcredist2013
  from 'https://download.microsoft.com/download/0/5/6/056dcda9-d667-4e27-8001-8a0c6971d6b1/vcredist_x86.exe'
Progress: 100% - Completed download of C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist2013\12.0.40660.20180427\vcredist_x86.exe (6.21 MB).
Download of vcredist_x86.exe (6.21 MB) completed.
Hashes match.
Installing vcredist2013...
vcredist2013 has been installed.
  vcredist2013 may be able to be automatically uninstalled.
 The install of vcredist2013 was successful.
  Software installed as 'exe', install location is likely default.

chocolatey-core.extension v1.3.5.1 [Approved]
chocolatey-core.extension package files install completed. Performing other installation steps.
 Installed/updated chocolatey-core extensions.
 The install of chocolatey-core.extension was successful.
  Software installed to 'C:\ProgramData\chocolatey\extensions\chocolatey-core'

chocolatey-windowsupdate.extension v1.0.4 [Approved]
chocolatey-windowsupdate.extension package files install completed. Performing other installation steps.
 Installed/updated chocolatey-windowsupdate extensions.
 The install of chocolatey-windowsupdate.extension was successful.
  Software installed to 'C:\ProgramData\chocolatey\extensions\chocolatey-windowsupdate'

KB3035131 v1.0.3 [Approved]
kb3035131 package files install completed. Performing other installation steps.
Skipping installation because update KB3035131 does not apply to this operating system (Microsoft Windows Server Datacenter).
 The install of kb3035131 was successful.
  Software install location not explicitly set, could be in package or
  default install location if installer.

KB3033929 v1.0.5 [Approved]
kb3033929 package files install completed. Performing other installation steps.
Skipping installation because update KB3033929 does not apply to this operating system (Microsoft Windows Server Datacenter).
 The install of kb3033929 was successful.
  Software install location not explicitly set, could be in package or
  default install location if installer.

KB2919442 v1.0.20160915 [Approved]
kb2919442 package files install completed. Performing other installation steps.
Skipping installation because this hotfix only applies to Windows 8.1 and Windows Server 2012 R2.
 The install of kb2919442 was successful.
  Software install location not explicitly set, could be in package or
  default install location if installer.

KB2919355 v1.0.20160915 [Approved]
kb2919355 package files install completed. Performing other installation steps.
Skipping installation because this hotfix only applies to Windows 8.1 and Windows Server 2012 R2.
 The install of kb2919355 was successful.
  Software install location not explicitly set, could be in package or
  default install location if installer.

KB2999226 v1.0.20181019 [Approved] - Possibly broken
kb2999226 package files install completed. Performing other installation steps.
Skipping installation because update KB2999226 does not apply to this operating system (Microsoft Windows Server Datacenter).
 The install of kb2999226 was successful.
  Software install location not explicitly set, could be in package or
  default install location if installer.

vcredist140 v14.28.29914 [Approved]
vcredist140 package files install completed. Performing other installation steps.
Downloading vcredist140-x86
  from 'https://download.visualstudio.microsoft.com/download/pr/85d47aa9-69ae-4162-8300-e6b7e4bf3cf3/14563755AC24A874241935EF2C22C5FCE973ACB001F99E524145113B2DC638C1/VC_redist.x86.exe'
Progress: 100% - Completed download of C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist140\14.28.29914\VC_redist.x86.exe (13.66 MB).
Download of VC_redist.x86.exe (13.66 MB) completed.
Hashes match.
Installing vcredist140-x86...
vcredist140-x86 has been installed.
Downloading vcredist140-x64 64 bit
  from 'https://download.visualstudio.microsoft.com/download/pr/85d47aa9-69ae-4162-8300-e6b7e4bf3cf3/52B196BBE9016488C735E7B41805B651261FFA5D7AA86EB6A1D0095BE83687B2/VC_redist.x64.exe'
Progress: 100% - Completed download of C:\Users\ContainerAdministrator\AppData\Local\Temp\chocolatey\vcredist140\14.28.29914\VC_redist.x64.exe (14.19 MB).
Download of VC_redist.x64.exe (14.19 MB) completed.
Hashes match.
Installing vcredist140-x64...
vcredist140-x64 has been installed.
  vcredist140 may be able to be automatically uninstalled.
 The install of vcredist140 was successful.
  Software installed as 'exe', install location is likely default.

vcredist2015 v14.0.24215.20170201 [Approved]
vcredist2015 package files install completed. Performing other installation steps.
 The install of vcredist2015 was successful.
  Software install location not explicitly set, could be in package or
  default install location if installer.

vcredist2017 v14.16.27033 [Approved]
vcredist2017 package files install completed. Performing other installation steps.
 The install of vcredist2017 was successful.
  Software install location not explicitly set, could be in package or
  default install location if installer.

vcredist-all v1.0.0 [Approved] - Possibly broken
vcredist-all package files install completed. Performing other installation steps.
 The install of vcredist-all was successful.
  Software install location not explicitly set, could be in package or
  default install location if installer.

Chocolatey installed 13/16 packages. 3 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Installed:
 - kb2919355 v1.0.20160915
 - vcredist2012 v11.0.61031
 - kb3033929 v1.0.5
 - chocolatey-core.extension v1.3.5.1
 - kb2999226 v1.0.20181019
 - vcredist2015 v14.0.24215.20170201
 - kb2919442 v1.0.20160915
 - vcredist-all v1.0.0
 - vcredist2017 v14.16.27033
 - vcredist140 v14.28.29914
 - vcredist2013 v12.0.40660.20180427
 - kb3035131 v1.0.3
 - chocolatey-windowsupdate.extension v1.0.4

Failures
 - vcredist2005 (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\vcredist2005\tools\chocolateyInstall.ps1'.
 See log for details.
 - vcredist2008 (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\vcredist2008\tools\chocolateyInstall.ps1'.
 See log for details.
 - vcredist2010 (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\vcredist2010\tools\chocolateyInstall.ps1'.
 See log for details.

Did you know the proceeds of Pro (and some proceeds from other
 licensed editions) go into bettering the community infrastructure?
 Your support ensures an active community, keeps Chocolatey tip top,
 plus it nets you some awesome features!
 https://chocolatey.org/compare

UPDATE: The installation seems successful w/ ignored checksums:

> choco install -y --ignore-checksums vcredist-all;
...

Chocolatey installed 16/16 packages.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Installed:
 - kb2919355 v1.0.20160915
 - vcredist2012 v11.0.61031
 - kb3033929 v1.0.5
 - chocolatey-core.extension v1.3.5.1
 - kb2999226 v1.0.20181019
 - vcredist2005 v8.1.0.20160118
 - vcredist2015 v14.0.24215.20170201
 - vcredist2008 v9.0.30729.6163
 - vcredist2010 v10.0.40219.325
 - kb2919442 v1.0.20160915
 - vcredist-all v1.0.0
 - vcredist2017 v14.16.27033
 - vcredist140 v14.28.29914
 - vcredist2013 v12.0.40660.20180427
 - kb3035131 v1.0.3
 - chocolatey-windowsupdate.extension v1.0.4
jberezanski commented 3 years ago

Great, Microsoft is apparently on an in-place installer update spree.

Actually, this is not a problem with vcredist-all, but rather with those specific packages and should be reported to maintainers of those packages. It so happens, however, that I'm also one of the maintainers of vcredist2008 and vcredist2010 (which live in https://github.com/chocolatey-community/chocolatey-coreteampackages/tree/master/manual). I've already prepared a fix for 2010 and I guess I'll do 2008 tomorrow.

As for 2005, I can see that it has the same maintainer as vcredist2010 had until very recently - when we took over that package because the maintainer did not respond. So we probably should take over 2005, too.

mloskot commented 3 years ago

Great, Microsoft is apparently on an in-place installer update spree.

I'm a simple builder of container images and it drops a bomb of terrible user experience of Microsoft's packages indeed!

Thank you for helping out!

mloskot commented 3 years ago

https://twitter.com/VisualStudio/status/1393203192629010434

@VisualStudio In any case, we'll pass to our team the URL you've sent us to check it.

jberezanski commented 3 years ago

Fixes done, awaiting PR review (and chocolatey.org admins approval of taking over vcredist2005): https://github.com/chocolatey-community/chocolatey-coreteampackages/pull/1654 (2008, 2010) https://github.com/chocolatey-community/chocolatey-coreteampackages/pull/1657 (2005)

jberezanski commented 3 years ago

All vcredistNNNN packages have been fixed. However, due to a versioning scheme fix in 2005, vcredist-all needed a fix in the dependency version. It is now pending moderation.

slonopotamus commented 3 years ago

Is it possible to ping someone who is responsible for the moderation process?

mwallner commented 3 years ago

~ done :smile:

slonopotamus commented 3 years ago

Possibly this issue should be closed then?

mloskot commented 3 years ago

Yes, unless @jberezanski knows a reason not to

jberezanski commented 3 years ago

No, I was kind of waiting to see if any other vcredists would get the same kind of in-place update, but I guess all is done.

mloskot commented 3 years ago

Thank you @jberezanski once again