search

jberezanski / ChocolateyPackages

Chocolatey packages maintained by me
MIT License
83 stars 51 forks source link

Update netfx-4.8 package to fix revoked certificate error preventing installation #133

Closed halmartin closed 1 year ago

halmartin commented 1 year ago

The installer fetched by the netfx-4.8 package is currently outdated and fails to install due to a revoked certificate.

This PR updates the .NET 4.8 installer to release 528049, which successfully installs (tested on Windows 10 x64).

Let me know if I need to fix anything, first time editing a chocolatey package!

jberezanski commented 1 year ago

Thank you for reaching out.

There are a couple of points to be addressed in this PR:

  1. In addition to this package (netfx-4.8), the dotnetfx package should be modified in the same way.
  2. For versioning the packages, I don't use the technical build numbers from the binaries. Rather, I use the "display version" (4.8.0 in this case) for the first three segments and use the package version notation (date of last package modification) for package updates.
  3. The Release value is used for detecting the installation of this .NET version and does not change with patches/installer updates. The values for .NET 4.8 differ between operating systems and are documented here. The package needs to use the lowest value across operating systems, so it should stay at 528040.
halmartin commented 1 year ago

Thanks for the feedback. I'll address points 1 and 2.

The Release value is used for detecting the installation of this .NET version and does not change with patches/installer updates. The values for .NET 4.8 differ between operating systems and are documented here. The package needs to use the lowest value across operating systems, so it should stay at 528040.

The .NET release in the registry is 528049 after installation with the 68C9986A8DCC0214D909AA1F31BEE9FB5461BB839EDCA996A75B08DDFFC1483F installer.

Do I understand correctly that the value should remain 528040 even though that's not what the installed .NET release is?

halmartin commented 1 year ago

dotnetfx is actually referencing the same installer (68C9986A8DCC0214D909AA1F31BEE9FB5461BB839EDCA996A75B08DDFFC1483F) as this PR. I'll just change netfx-4.8 to match dotnetfx

jberezanski commented 1 year ago

Do I understand correctly that the value should remain 528040 even though that's not what the installed .NET release is?

Yes, because the value does not depend on the installer, but on the operating system. (Surprising, I agree.) The package must work on all supported systems. The Release value is only used in a "greater or equal than" comparison, so the package can use the lowest value it can possibly encounter.

jberezanski commented 1 year ago

dotnetfx is actually referencing the same installer

Oh, is that so? Shame on me, then, for forgetting to update netfx-4.8...

jberezanski commented 1 year ago

Thank you for the contribution. I'll publish the updated package shortly.