search

jberger / Galileo

A Simple Modern Perl CMS
http://galileo-cms.herokuapp.com
166 stars 38 forks source link

Fix dump could deal the encoding #25

Closed keedi closed 10 years ago

keedi commented 10 years ago

Current version of galileo dump command cannot dump the utf-8 encoded pages like snowflake properly. (Of course utf-8 encoded CJK characters cannot be dumped to file.) This patch adds --encoding or -e options for dump command. By default it does nothing like original code. But if someone have trouble with dump due to utf-8 encoded characters then --encoding=utf-8 option could help.

I've just tested under default SQLite database (as Galileo default setting) and it just works. And added document is very shoddy so please consider that. :)

jberger commented 10 years ago

Wow, thanks for the pr and the tests too! I might make a couple tweaks here and there, but this is an example of an outstanding pr!

jberger commented 10 years ago

Released as version 0.033 to CPAN. Thanks again!

jberger commented 10 years ago

Btw I also made the dump output UTF-8 by default

keedi commented 10 years ago

Thanks for fast release. Now page dump works well with my CJK utf-8 characters. :+1: