search

jberger / Mojo-ACME

Mojo-based ACME-protocol client
10 stars 5 forks source link

Test fails because of removed Mojo::Transaction::success #15

Open CodingMinds opened 2 years ago

CodingMinds commented 2 years ago 
Building and testing Mojo-ACME-0.13
cp lib/Mojolicious/Plugin/ACME.pm blib/lib/Mojolicious/Plugin/ACME.pm
cp lib/Mojolicious/Plugin/ACME/Command/acme/cert.pm blib/lib/Mojolicious/Plugin/ACME/Command/acme/cert.pm
cp lib/Mojo/ACME/ChallengeServer.pm blib/lib/Mojo/ACME/ChallengeServer.pm
cp lib/Mojolicious/Plugin/ACME/Command/acme/account/register.pm blib/lib/Mojolicious/Plugin/ACME/Command/acme/account/register.pm
cp lib/Mojolicious/Plugin/ACME/Command/acme/account.pm blib/lib/Mojolicious/Plugin/ACME/Command/acme/account.pm
cp lib/Mojo/ACME/Key.pm blib/lib/Mojo/ACME/Key.pm
cp lib/Mojolicious/Plugin/ACME/Command/acme/cert/generate.pm blib/lib/Mojolicious/Plugin/ACME/Command/acme/cert/generate.pm
cp lib/Mojo/ACME.pm blib/lib/Mojo/ACME.pm
cp lib/Mojolicious/Plugin/ACME/Command/acme.pm blib/lib/Mojolicious/Plugin/ACME/Command/acme.pm
cp lib/Mojolicious/Plugin/ACME/Command.pm blib/lib/Mojolicious/Plugin/ACME/Command.pm
cp lib/Mojo/ACME/CA.pm blib/lib/Mojo/ACME/CA.pm
Mojo::Reactor::Poll: I/O watcher failed: Can't locate object method "success" via package "Mojo::Transaction::HTTP" at /root/.cpanm/work/1627989926.152919/Mojo-ACME-0.13/blib/lib/Mojo/ACME.pm line 36.
Mojo::Reactor::Poll: I/O watcher failed: Can't locate object method "success" via package "Mojo::Transaction::HTTP" at /root/.cpanm/work/1627989926.152919/Mojo-ACME-0.13/blib/lib/Mojo/ACME.pm line 36.
t/acme.t .. 
No subtests run 
t/key.t ... ok

Regarding https://github.com/mojolicious/mojo/issues/1266#issuecomment-447803216 $tx->success should be replaced with !$tx->error.

GurvanKervern commented 1 year ago

I made a little fix for this, how would I go about getting the right to make a PR?