jberger / Mojo-ACME

Mojo-based ACME-protocol client
10 stars 5 forks source link

Error output #6

Closed nickandrew closed 8 years ago

nickandrew commented 8 years ago

If the negotiation with LetsEncrypt doesn't go well, Mojo-ACME provides little detail on the cause of the error.

These commits add printed response codes from the LetsEncrypt server and parsed error messages, for the two errors which I encountered.

s1037989 commented 8 years ago

:+1:

This helped me!!

Currently:

failed to get cert at /home/stefan/perl5/lib/perl5/Mojo/ACME.pm line 90.

No cert was generated

With this patch applied:

Failed to get cert: 429 Unknown - Error creating new cert :: Too many certificates already issued for exact set of domains: x.y.z at /home/stefan/perl5/lib/perl5/Mojo/ACME.pm line 100.

No cert was generated
jberger commented 8 years ago

My apologies. This PR slipped under my radar while I was on vacation. I've decided to address this a different way. There were more cases that should have their error parsed out and using that code block in each case would have gotten bulky.

s1037989 commented 8 years ago

Love it!! Thanks!!