add windows 10 support to detect_chrome_executable

[dmanto]

detect_chrome_executable now will work in Windows 10 (tested with strawberry perl 5.26.1, also on cygwin with correspondig perl 5.26.1)

[jberger]

oh I like the notion of adding appveyor to this in the same patch, that would go a long way to proving that functionality to me while I cannot test it myself (mac/linux guy). I should also add travis while we're at it.

[dmanto]

ok now is passing tests at appveyor, but

• I have some "gpu_process_transport_factory" error from chrome looking at appveyor console though:

  
  ...
  prove -l
  [0319/221733.426:ERROR:gpu_process_transport_factory.cc(1019)] Lost UI shared context.
  DevTools listening on ws://127.0.0.1:1056/devtools/browser/e3f5d362-f08d-4e9e-8373-62cb1c900fe2
  t\basic.t ..... ok
  t\from_url.t .. ok
  [0319/221748.672:ERROR:gpu_process_transport_factory.cc(1019)] Lost UI shared context.
  DevTools listening on ws://127.0.0.1:1064/devtools/browser/205f3b1c-b520-4b2f-b0f2-14f4e60c86fb
  t\tester.t .... ok
  All tests successful.
  Files=3, Tests=21, 91 wallclock secs ( 0.03 usr +  0.03 sys =  0.06 CPU)
  Result: PASS
  Discovering tests...OK
  Updating build cache...
  Cache 'C:\strawberry' - Up to date
  Build success

- I don't get any warning running the tests locally on a win10 machine (not even the "DevTools listening on..." lines)

- I also get that gpu error from chrome when I run on Ubuntu 16.04.2 LTS, (tests also pass):

daniel@localhost:~/Mojo-Chrome$ prove -l t/basic.t ..... [0319/222930.323742:ERROR:gpu_process_transport_factory.cc(1019)] Lost UI shared context.

DevTools listening on ws://127.0.0.1:36071/devtools/browser/d3c9a8bf-5a38-4047-a3d8-f666c679338b t/basic.t ..... ok t/from_url.t .. ok t/tester.t .... [0319/222931.907437:ERROR:gpu_process_transport_factory.cc(1019)] Lost UI shared context.

DevTools listening on ws://127.0.0.1:48977/devtools/browser/59ced763-570d-4109-9b12-1beceb5f0abb t/tester.t .... ok All tests successful. Files=3, Tests=21, 3 wallclock secs ( 0.04 usr 0.01 sys + 1.90 cusr 0.25 csys = 2.20 CPU) Result: PASS daniel@localhost:~/Mojo-Chrome$

I am trying to investigate why are we getting those errors, not very sure what they are. I had a lot more errors and warning until I update chrome-browser to the last version (65.0.3325.162-1)

[dmanto]

Sorry I didn't mean to close it

[heikojansen]

AFAIK there's a "--disable-gpu" flag, which is said to be needed on Windows (only) with headless Chrome. Unfortunately I cannot remember right now where I read that. Maybe that would "fix" (evade?) the errors.