search

jberger / Mojo-IOLoop-ForkCall

Deprecated! Use Mojo::IOLoop::Subprocess instead
https://mojolicious.org/perldoc/Mojo/IOLoop/Subprocess
5 stars 2 forks source link

Comments from IRC, regading EventEmitter, pid and plugin #1

Closed jhthorsen closed 10 years ago

jhthorsen commented 10 years ago

Hi,

I'm copy pasting parts of the IRC log here, just to make sure you don't miss it:

--- 25. Nov 07:41:12 [batman] jberger: your module got so simple it's funny :) [batman] jberger: still would very much like if i could get the pid and kill EventEmitter. [batman] jberger_: https://gist.github.com/jhthorsen/7637407 # what do you think?

Do you have any tricks up your sleeve to make sure the child is killed, in case something goes wrong?

And I think I would rather add the EventEmitter later on if someone ask for the finish() event. I really don't like memory leaks. Even if they are just temporarily.

Sorry for merging all comments in one task. Just didn't see the point of adding a bunch of issues on a module that's not yet released :)

jhthorsen commented 10 years ago

I'm happy :)

jberger commented 10 years ago

Cool