search

jbergstroem / hadolint-gh-action

A hadolint linter for github actions that provides code annotations (and more)
MIT License
12 stars 5 forks source link

fix: don't download hadolint twice #135

Closed SMoraisAnsys closed 7 months ago

SMoraisAnsys commented 8 months ago

Problem When one wants to use hadolint-gh-action multiple times, an error is raised because the bin directory already exists, see https://github.com/jbergstroem/hadolint-gh-action/issues/134

Solution Use option -p of mkdir

Fixes #134

jbergstroem commented 8 months ago

Thanks a lot for the effort. Almost there!

SMoraisAnsys commented 7 months ago

Hi @jbergstroem, is there a chance that this PR gets accepted next week with a following new release ? If there is something that is missing, feel free to point it out :)

jbergstroem commented 7 months ago

Hi @jbergstroem, is there a chance that this PR gets accepted next week with a following new release ? If there is something that is missing, feel free to point it out :)

Was AFK this weekend but yeah it'll land in 24h

SMoraisAnsys commented 7 months ago

Hi @jbergstroem, sorry to be so insistent but I'd really like to be able to use these developments through your action. Would it be possible to have a release this week?

jbergstroem commented 7 months ago

Hi @jbergstroem, sorry to be so insistent but I'd really like to be able to use these developments through your action. Would it be possible to have a release this week?

Apologise for the delay; took the opportunity to refactor the install into its own shell script. I'm almost done.

jbergstroem commented 7 months ago

@SMoraisAnsys ok, I think we're in good shape. How does it look for you?

SMoraisAnsys commented 7 months ago

Yeah, everything look fine. Thanks for your help and great job with the refactoring !