search

jbergstroem / mariadb-alpine

A tiny and fast MariaDB container
MIT License
72 stars 19 forks source link

feat: add tzdata #266

Closed caveman99 closed 10 months ago

caveman99 commented 10 months ago

so the container can be setup to use different timezones via the TZ ENV Variable

jbergstroem commented 10 months ago

Thanks for the contribution! Do you think you're able to make a test for this? Check this file for inspiration: https://github.com/jbergstroem/mariadb-alpine/blob/main/test/config.sh

You'd essentially set TZ and then check that its properly set in SHOW SESSION VARIABLES LIKE 'system_time_zone'

caveman99 commented 10 months ago

Sure thing, I'll commit later tonight.

caveman99 commented 10 months ago

@jbergstroem sorry for taking so long, the included test should work, at least it does on my fork :-)

jbergstroem commented 10 months ago

@jbergstroem sorry for taking so long, the included test should work, at least it does on my fork :-)

Great! will take a look later today.

jbergstroem commented 10 months ago

Thanks a lot for your contribution!

caveman99 commented 10 months ago

Thanks for including the patch... i had a compose stack running where the app was complaining that the DB was one hour off (CET vs. UTC). It was working, but the permanent error in the status bar was annoying and irritating for customers... :-)

jbergstroem commented 10 months ago

Thanks for including the patch... i had a compose stack running where the app was complaining that the DB was one hour off (CET vs. UTC). It was working, but the permanent error in the status bar was annoying and irritating for customers... :-)

I will update the latest image shortly.

jbergstroem commented 10 months ago

Job here: https://github.com/jbergstroem/mariadb-alpine/actions/runs/7145497765

jbergstroem commented 10 months ago

10.11.5 and latest now contains the feature (bug? 😄) https://hub.docker.com/r/jbergstroem/mariadb-alpine/tags