search

jbergstroem / mariadb-alpine

A tiny and fast MariaDB container
MIT License
72 stars 19 forks source link

dockerfile: optimize cleanup #81

Closed jbergstroem closed 3 years ago

jbergstroem commented 3 years ago

We previously called tail on output from apk. This is a remnant from an older script that handled output differently.

This means we now remove more files that shouldn't be part of the distribution.

jbergstroem commented 3 years ago

I am not sure why removing the comment is better

Just felt like we were stating the obvious. As a user they likely won't understand most of the work done in there and as a dev/mysql developer you likely have worked with the hosts table before. You think it serves a purpose?

Also, I am rewriting the test suite with bash_unit (#67) and will land that before doing continuous work – too many corner cases I wanna test properly.

jbergstroem commented 3 years ago

Maybe leave it

Done