search

jberkel / android-plugin

An sbt plugin for Android development in Scala
https://groups.google.com/forum/#!forum/scala-on-android
Other
476 stars 113 forks source link

Add setting to control the inclusion of Scala libs in the APK #163

Closed fxthomas closed 11 years ago

fxthomas commented 11 years ago

After all that free advertising Facebook decided to give to our favorite Dalvik issue, I just learned that it had been fixed in recent versions of Android. Therefore, no more Proguard for development on Android 4.1+, which is amazing news!

Unfortunately the android-plugin absolutely wanted to skip the inclusion of the Scala libs in the generated APK when disabling Proguard. I added a setting key (skip-scala-library) to control that.

The default is "Use Proguard" and "Include Scala" (i.e. useProguard := true and skipScalaLibrary := false), which I believe is should work for most people.

fxthomas commented 11 years ago

Hm, Travis build failed. publish-local and test worked on my computer though.

appamatto commented 11 years ago

Oops, make that: https://github.com/appamatto/android-plugin/commit/c272f3c20166dfe91d3c41789624a909eda431a0