search

jberkel / android-plugin

An sbt plugin for Android development in Scala
https://groups.google.com/forum/#!forum/scala-on-android
Other
476 stars 113 forks source link

Simplify settings for library predexing #164

Closed fxthomas closed 11 years ago

fxthomas commented 11 years ago

I thought the code handling predexing for the second parameter of dxOpts was not very straightforward. I replaced it with my own setting key toggling predexing for every library input.

Basically, if predexLibraries is false, then run dxTask as before, else predex every file.jar input as a file.jar.apk predexed cache that won't be rebuilt unless the origin JAR has changed, then link them to the compiled classes.

appamatto commented 11 years ago

Merged into my master: https://github.com/appamatto/android-plugin/commit/ea93750d923439f16d9cae3ff758c5864f3884ef

I also removed the second element of the dxOpts tuple and renamed the memory string to dxMemory to play better with your simplification.

fxthomas commented 11 years ago

Perfect! I wasn't sure what I should do about dxOpts, but it sure seemed redundant to keep it that way.