search

jberkel / android-plugin

An sbt plugin for Android development in Scala
https://groups.google.com/forum/#!forum/scala-on-android
Other
476 stars 113 forks source link

Add libs to the native library folders #38

Closed appamatto closed 13 years ago

paulbutcher commented 13 years ago

This looks good to me :-)

One question is whether, instead of having "libs" hard-coded, we should pass it in to ApkBuilder so that it can be declared as a default in the AndroidProject object and potentially overridden by a derived project?

Personally, I doubt that any derived project will actually do this, but it might be the right thing to do just for consistency with the code that's already there?

appamatto commented 13 years ago

Sure, good idea. I also was curious about proguard--is the config hard-coded, or is there some way to affect it via a config file in the project?

On Thu, May 5, 2011 at 12:29 PM, paulbutcher < reply@reply.github.com>wrote:

This looks good to me :-)

One question is whether, instead of having "libs" hard-coded, we should pass it in to ApkBuilder so that it can be declared as a default in the AndroidProject object and potentially overridden by a derived project?

Personally, I doubt that any derived project will actually do this, but it might be the right thing to do just for consistency with the code that's already there?

Reply to this email directly or view it on GitHub: https://github.com/jberkel/android-plugin/pull/38#issuecomment-1106985

paulbutcher commented 13 years ago

Re proguard - I've not yet really looked at this bit of the plugin, but I suspect that you should be able to change its behaviour by overriding proguardTask or proguardAction? Which certainly isn't ideal, but should work?