search

jberkel / sms-backup-plus

Backup Android SMS, MMS and call log to Gmail / Gcal / IMAP
https://play.google.com/store/apps/details?id=com.zegoggles.smssync
Apache License 2.0
1.8k stars 499 forks source link

backing up to SMS folder in gmail does not show the correct names #1060

Open thinkscriptfan opened 3 years ago

thinkscriptfan commented 3 years ago

Hi , I am using smsbackup+ on pixel 3axl , latest android . recently , I have noticed that sometimes my text to some known contacts is not backed up correctly . instead of showing from me , it shows from +1xxxxxxx +1xxxxxxx@unknown.email , and instead of showing SMS with the name of the receiver , it shows SMS with +1xxxxxxx ( where +1xxxxxxx is my cell number )

I just noticed that this has been happening only in the last 2 years,

This is very serious , as the conversation threads can not be valid anymore under a certain name.

Expected behaviour from me SMS with " the name of the receiver"

Actual behaviour from +1xxxxxxx +1xxxxxxx@unknown.email SMS with +1xxxxxxx

Steps to reproduce the behaviour ? sometimes happens , not sure how to reproduce.

Please specify the following:

kurahaupo commented 3 years ago

I'm pretty sure this is a continuation of a known issue. I will check for related issues shortly.

Essentially, the API used to access an individual message presents a list of addresses (phone numbers) associated with it, in no particular order.

When this app was written they were presented with the "sender" as the first address, but at some point the order became randomized, and a "type" tag was added. This is why you see your own address appearing instead of the other party's.

kurahaupo commented 3 years ago

@jberkel - I'd like your thoughts on this plan:

What needs to happen is to inspect the "type" tag on each address to find which one is the sender and then to choose based on incoming or outgoing whether the sender is the "other party" or not.

In the case of group messages it gets more complicated, as for incoming messages it would need to identify which of the recipients are "self" and which are "others". Possibly this could be learned from the 2-party messages.

If that can't be made to work reliably, then there are several options:

  1. save a separate copy for each participant
  2. include all the participants in one message, including the local user's address. They might need to be sorted & hashed into a single "address"; that will depend on conversation works in detail.
kurahaupo commented 3 years ago

Duplicate of #390

kurahaupo commented 3 years ago

Possibly related to #621

kurahaupo commented 3 years ago

Possibly related to #671

kurahaupo commented 3 years ago

Possibly related to #704

kurahaupo commented 3 years ago

Possibly related to #621

kurahaupo commented 3 years ago

Possibly related to #663

kurahaupo commented 3 years ago

Duplicate of #676

kurahaupo commented 3 years ago

See new bug classification misattribution

kurahaupo commented 3 years ago

See additional classification half-missing, as some of the issues with that tag may be hidden variants on the misattribution tag.

kurahaupo commented 3 years ago

@jberkel FYI need to make allowance that some MMS messages include the sender among the recipients as well