jberkel / sms-backup-plus

Backup Android SMS, MMS and call log to Gmail / Gcal / IMAP
https://play.google.com/store/apps/details?id=com.zegoggles.smssync
Apache License 2.0
1.81k stars 498 forks source link

Incoming SMS during Restore #809

Open NickHirras opened 7 years ago

NickHirras commented 7 years ago

If I'm doing a long running restore, say it takes a few hours. While that's running and SMS Backup is set as the default messaging app, will new incoming texts get dropped / lost?

Woi commented 6 years ago

I don't know the answer. But you could just enable flight mode and re-enable wifi for the restore.

nbali commented 6 years ago

I have a feeling that it's lost. At least for me the default app wasn't restored, and I went days without any SMS. It might be coincidence, but I suspect it's not.

ps.: successfully duplicated this one before finding it with https://github.com/jberkel/sms-backup-plus/issues/851

jberkel commented 6 years ago

yes, there's a chance that it can get lost. this is unfortunately a result of Android's permission design, which requires the app to become the default SMS app in order to write to the database. everytime you start SMS Backup it will check if it's still the default app and ask you to switch back.

I'm sure the process could be improved, but as I said there are substantial design flaws in the OS itself.

https://github.com/jberkel/sms-backup-plus/#faq-restore-default-app

NickHirras commented 6 years ago

Could functionality be added to allow sms-backup-plus to continue to receive and store texts as unread while it's active? Then when another app is restored as default client they'd show up in that app?

On Mar 14, 2018 6:56 AM, "Jan Berkel" notifications@github.com wrote:

yes, there's a chance that it can get lost. this is unfortunately a result of Android's permission design, which requires the app to become the default SMS app in order to write to the database. everytime you start SMS Backup it will check if it's still the default app and ask you to switch back.

I'm sure the process could be improved, but as I said there are substantial design flaws in the OS itself.

https://github.com/jberkel/sms-backup-plus/#faq-restore-default-app

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jberkel/sms-backup-plus/issues/809#issuecomment-372995822, or mute the thread https://github.com/notifications/unsubscribe-auth/ADuvzCSC_gqzrHdOdeIf4W8jH6sXqOt-ks5teQVZgaJpZM4PoKiS .

jberkel commented 6 years ago

@imnes I need to check – it should be possible. but there's always a risk of something going wrong (a bug in the receiving code etc), that's why enabling flightmode during long restore operations is the safest choice right now

nbali commented 6 years ago

Even if that's not possible, a warning pop-up about this would be useful if the phone isn't in flightmode. (Obviously a prompt to turn it on would be best, but I have no idea if it's doable.)

NickHirras commented 6 years ago

I would think there's an android SMS library that can be utilized but haven't done much research yet. If I get some free time soon I'll look into some options and what it would take to integrate!

On Wed, Mar 14, 2018 at 4:44 PM, Balázs Németh notifications@github.com wrote:

Even if that's not possible, a warning pop-up about this would be useful if the phone isn't in flightmode. (Obviously a prompt to turn it on would be best, but I have no idea if it's doable.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jberkel/sms-backup-plus/issues/809#issuecomment-373185183, or mute the thread https://github.com/notifications/unsubscribe-auth/ADuvzE1gFah8UVE1U11VgCDwu0jCBD1tks5teY9EgaJpZM4PoKiS .

jberkel commented 6 years ago

I'll add a more prominent warning. There's already a popup, but it doesn't mention the risk of data loss.

jberkel commented 6 years ago

@imnes @nbali will be fixed in next beta (-14). the message is saved, but no notification will be generated for it. it will be visible in the normal messages app.

jberkel commented 6 years ago

@nbali @imnes It'd be cool if you could verify that this actually works. If have only tested on an emulator.

NickHirras commented 6 years ago

Did you add sms receipt or that notice?

On Thu, Mar 22, 2018, 7:24 PM Jan Berkel notifications@github.com wrote:

@nbali https://github.com/nbali @imnes https://github.com/imnes I'd be cool if you could verify that this actually works. If have only tested on an emulator.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jberkel/sms-backup-plus/issues/809#issuecomment-375500290, or mute the thread https://github.com/notifications/unsubscribe-auth/ADuvzFyCRQo2qYgrpEKtVbdBYCdfwpNCks5thEDWgaJpZM4PoKiS .

jberkel commented 6 years ago

@imnes it saves the incoming SMS to the storage. the notice was updated as well.

NickHirras commented 6 years ago

Awesome! Will give it a try and report back!

On Thu, Mar 22, 2018, 7:39 PM Jan Berkel notifications@github.com wrote:

@imnes https://github.com/imnes it saves the incoming SMS to the storage. the notice was updated as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jberkel/sms-backup-plus/issues/809#issuecomment-375502560, or mute the thread https://github.com/notifications/unsubscribe-auth/ADuvzGG64-lM_FyO2woKzUgJ6QDafgV_ks5thERDgaJpZM4PoKiS .

jcrben commented 6 years ago

@imnes can you try? would be good to get confirmation before 1.5.11

NickHirras commented 6 years ago

Is it in the current release in app store or do I need to sign up for a beta or something?

On Sat, Apr 14, 2018, 10:55 AM Ben Creasy notifications@github.com wrote:

@imnes https://github.com/imnes can you try? would be good to get confirmation before 1.5.11

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jberkel/sms-backup-plus/issues/809#issuecomment-381338877, or mute the thread https://github.com/notifications/unsubscribe-auth/ADuvzKwO9dXYYb1AQIoyUSTJzr0iSot9ks5tohvdgaJpZM4PoKiS .

jcrben commented 6 years ago

https://github.com/jberkel/sms-backup-plus#beta

NickHirras commented 6 years ago

I installed the latest beta last night and attempted a backup overnight. When I woke up it had shown an I/O error, not sure if I'll have a chance to test restore functionality before next week.

On Sat, Apr 14, 2018 at 9:59 PM, Ben Creasy notifications@github.com wrote:

https://github.com/jberkel/sms-backup-plus#beta

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jberkel/sms-backup-plus/issues/809#issuecomment-381376452, or mute the thread https://github.com/notifications/unsubscribe-auth/ADuvzGagYDQbMGBKI8YUwkNm1dZOys6_ks5toreLgaJpZM4PoKiS .