Bug when syncing a package with a prefix set

jbernard / dotfiles

Dotfile management made easy

https://pypi.org/project/dotfiles/

Other

577 stars 61 forks source link

Bug when syncing a package with a prefix set #33

Closed jbernard closed 8 years ago

jbernard commented 10 years ago

A comment in issue #32 reveals a bug when using a prefix such as . along with packages.

I also have issues with packages.

When I put ".config" in my packages list, "dotfiles/.config/awesome" links to "..config/wesome".
when I put "config" in my packages list, .config is no longer recognized as a package.

niol commented 10 years ago

I've fixed this in my branch (which is unfortunately a bit different from yours) : niol/dotfiles@7789fe8550e9c15ef9d7ad868548702b5c897c4d . Maybe this will give you some hint about what to fix.

jbernard commented 10 years ago

@niol that is helpful, thanks. After adding a few more unit tests it seems that the package/prefix logic needs a bit of work, I hadn't seen it until now - I guess the prefix feature is not used so much.

I'd like to find some time to clean it up before I make additional changes... We'll see.