search

jbesomi / texthero

Text preprocessing, representation and visualization from zero to hero.
https://texthero.org
MIT License
2.89k stars 239 forks source link

Add version attribute #172

Open bhishanpdl opened 4 years ago

bhishanpdl commented 4 years ago

Usually python packages has attribute .__version__ and .__name__.

I would suggest adding these two attributes to this package TEXTHERO.

For example:

import numpy as np

print(np.__name__)
print(np.__version__)
henrifroese commented 4 years ago

Makes sense. I believe __name__ is already implemented automatically. Do you want to implement this @bhishanpdl ? You can read here how to start contributing :fireworks:

jbesomi commented 4 years ago

Agree with @bhishanpdl, it can be very useful. Actually, even if the task seems very trivial and simple, it's more subtle than that. In a previous version, I implemented this (before this commit) but this was given some problem (setup.cfg required texthero to be installed to install texthero?! 🙃). A better solution than the previous one is required :D

jbesomi commented 4 years ago

@bhishanpdl want to help with that?

harishsdev commented 3 years ago

i saw the solution for the above in torchaudio,can i submit PR by porting from torchaudio to texthero

bhishanpdl commented 3 years ago

@jbesomi and @harishsdev You guys are more than welcome to send the PR to the developers. I would greatly appreciate that.

jbesomi commented 3 years ago

Hey @harishsdev, sure, if torchaudio has a working solution, it would be great if you can port it to Texthero. Let me know, thanks!