search

jbesomi / texthero

Text preprocessing, representation and visualization from zero to hero.
https://texthero.org
MIT License
2.89k stars 239 forks source link

fillna should support customized fill content #182

Closed monkdou0 closed 3 years ago

monkdou0 commented 4 years ago

texthero.preprocessing.fillna() only replace the nan with writespace. It should support customized fill content

henrifroese commented 4 years ago

Makes sense. This looks like a good first issue! Do you want to work on this? @monkdou0 (you can ask all questions you have here and we'll help you)

monkdou0 commented 4 years ago

Of course. I will try and then give the PR

k0pernicus commented 3 years ago

I think this issue has been solved in #190, no?

jbesomi commented 3 years ago

Right, thank you @k0pernicus!