search

jbesomi / texthero

Text preprocessing, representation and visualization from zero to hero.
https://texthero.org
MIT License
2.89k stars 239 forks source link

Optional string in fillna #190

Closed Andre-Sacilotti closed 4 years ago

Andre-Sacilotti commented 4 years ago

Hey, i added an optional argument in fillna, for those, like me, who need to fill missing values with an custom string.

Example:

>>> hero.fillna(s, "Custom String!!")
0                I'm
1    Custom String!!
2    Custom String!!
3             You're
dtype: object
Andre-Sacilotti commented 4 years ago

Closes #182

henrifroese commented 4 years ago

Here we can see that your changes change a lot of "invisible" stuff (whitespace) in the whole preprocessing file, which of course we cannot accept as this leads to doctests failing. Not sure which Black version you are using? You can see here that we sadly have problems with the newest version; that might be the issue 😿

Andre-Sacilotti commented 4 years ago

Here we can see that your changes change a lot of "invisible" stuff (whitespace) in the whole preprocessing file, which of course we cannot accept as this leads to doctests failing. Not sure which Black version you are using? You can see here that we sadly have problems with the newest version; that might be the issue crying_cat_face

oh, i just saw the travis ci build failed, i'm using black-19.10b0, i'm trying to resolve this

Andre-Sacilotti commented 4 years ago

Okay, i think its working right now. Any tips or comments will be very helpful.

jbesomi commented 4 years ago

Hey @Andre-Sacilotti, looks great! Thank you!

And welcome to Texthero as a contributor, you can open a new PR and add your name in the README.md file! 👍