search

jbesomi / texthero

Text preprocessing, representation and visualization from zero to hero.
https://texthero.org
MIT License
2.89k stars 239 forks source link

Deprecated arguments on kmeans function call #222

Open svthiago opened 2 years ago

svthiago commented 2 years ago

When I tried to use kmeans I noticed that a couple of deprecated arguments were used to make the function call: precompute_distances and n_jobs. After I removed them it worked fine. Tried both on version 1.1.0 and 1.0.9. I would make a PR about it but the code on the main branch looks different from the one installed with pip install.

svthiago commented 2 years ago

This issue is happening on file representation.py lines 218 and 236.

jbesomi commented 2 years ago

Thanks, @svthiago. I will look into that and fix it soon. If you are interested to work on that and want to open a PR, that would be very appreciated!

akthammomani commented 2 years ago

@jbesomi Please let us know if there's any update in this error. Thanks for the support

jbesomi commented 2 years ago

Hey @akthammomani. I can look into that during the weekend. If you happen to have some free time and feel like contributing, I would love to receive your PR 🎉

akthammomani commented 2 years ago

Hi @jbesomi, as pointed out by @svthiago: The code on the main branch is different from the one installed with pip install.

Thank you