jbetancur / react-data-table-component

A responsive table library with built-in sorting, pagination, selection, expandable rows, and customizable styling.
https://react-data-table-component.netlify.app
Apache License 2.0
2.05k stars 413 forks source link

Columns can be reordered when reorder is disabled #1109

Closed TxJson closed 1 year ago

TxJson commented 2 years ago

Issue Check list

Describe the bug

If you have reorder disabled on your table columns, you can still make them reorder. This can be seen on the documentation as well when using the various stories (see GIF in Screenshots section). Sometimes this enables reorder for the whole table as well, although was unable to recreate that again for the example GIFs.

To Reproduce

Steps to reproduce the behavior:

  1. Disable reorder (assuming it is enabled)
  2. Go to your table and drag from just about the start of a column.
  3. You've now reordered the table.

Expected behavior

I expect it to not be possible to reorder the table when reorder is disabled.

Code Sandbox, Screenshots, or Relevant Code

GIF with my Table still-possible-to-reorder

GIF with table in Story still-possible-to-reorder-2

Versions (please complete the following information)

Additional context

N/A

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mcinarpro commented 7 months ago

Hello, I have the same issue. Reorder is disabled in my datatable and I can drag and drop cells. @TxJson @jbetancur Do you have a solution for this problem? Can you re-active this issue?

TxJson commented 7 months ago

@mcinarpro unfortunately the maintainer of this repository closed the issue so there has yet to be any fix to this, as far as I am aware.