search

jbetancur / react-data-table-component

A responsive table library with built-in sorting, pagination, selection, expandable rows, and customizable styling.
https://react-data-table-component.netlify.app
Apache License 2.0
2.04k stars 411 forks source link

Fix styled component errors 2 #1155

Closed jessewriter closed 1 year ago

jessewriter commented 1 year ago

building off off HendrikPetertje PR i also removed the final styled component errors for 'right' and 'sortActive'

netlify[bot] commented 1 year ago

Deploy Preview for react-data-table-component failed.

Name Link
Latest commit 8c3daa880264e79784f5f605180db44670878657
Latest deploy log https://app.netlify.com/sites/react-data-table-component/deploys/64e664d0e0af990008d87311
jessewriter commented 1 year ago

not sure why there are netlify errors as this work just fine in my project and all the styled warnings are gone from my console. we have many different tables and no errors :/

jessewriter commented 1 year ago

ok i see that my $right fix did not work and those columns are still left oriented. error is gone but intended effect is wrong will investigate tmro. and i c that not updating the jest tests broke the checks

HendrikPetertje commented 1 year ago

heya @jessewriter, noticing the error you are trying to fix too now :) Do you want me to help you out so we can get this pull over the line?

jessewriter commented 1 year ago

heya @jessewriter, noticing the error you are trying to fix too now :) Do you want me to help you out so we can get this pull over the line?

yes sir, we are running this fork successfully but i never did update the unit tests. right and sortActive both cause issues and we fixed. can't remember if there were any more but 0 errors on our side. only unit tests remain

amirfaisalz commented 1 year ago

any update on this? the issue still persist

SamuelDowse commented 11 months ago

The issue is with styled-components version 6.x and above, the issue does not exist on styled-components version 5.x

This library needs updating to support styled-components version 6.x

allan-vera commented 8 months ago

Are there any suppression suggestions besides installing the correct version of style-components (for projects that dont use SC)