search

jbetancur / react-data-table-component

A responsive table library with built-in sorting, pagination, selection, expandable rows, and customizable styling.
https://react-data-table-component.netlify.app
Apache License 2.0
2.04k stars 411 forks source link

FIx sortActive issue #1176

Closed karimalden closed 8 months ago

netlify[bot] commented 10 months ago

Deploy Preview for react-data-table-component ready!

Name Link
Latest commit bcb803184b80f5b0c93945c9ba304d5e523b763a
Latest deploy log https://app.netlify.com/sites/react-data-table-component/deploys/6541509c4f89fb00087947ee
Deploy Preview https://deploy-preview-1176--react-data-table-component.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AlexMoutonNoble commented 10 months ago

Hi Kari, Not part of the team here but can you give some description of what the problem was for those of us playing at home? It lookslike you removed camelCase from this variable but its not hitting me why.

Thanks AM

ryan-williams commented 10 months ago

Not sure if this PR is the right fix but I think the problem is https://github.com/jbetancur/react-data-table-component/issues/1156#issuecomment-1735174483:

You'll need to use styled-components version 5.x not ^6.x. React-Data-Table-Component needs updating to use the latest styled-components library.

jbetancur commented 8 months ago

Thank you for this PR, however, a major update was required as part of a refactor I have been working on and this was fixed in https://github.com/jbetancur/react-data-table-component/pull/1195