search

jbetancur / react-data-table-component

A responsive table library with built-in sorting, pagination, selection, expandable rows, and customizable styling.
https://react-data-table-component.netlify.app
Apache License 2.0
2.04k stars 411 forks source link

Fix sortActive like an unknown prop using styledComponent transient props #1192

Closed JacksonSamuel42 closed 8 months ago

JacksonSamuel42 commented 8 months ago

fix "sortActive" is being sent through to the DOM, which will likely trigger a React console error. If you would like automatic filtering of unknown props.

fix this problem using transient props https://styled-components.com/docs/api#transient-props

netlify[bot] commented 8 months ago

Deploy Preview for react-data-table-component ready!

Name Link
Latest commit 823f23b1b3460cd3cd2c9b1580bba2f6a0d406cc
Latest deploy log https://app.netlify.com/sites/react-data-table-component/deploys/6596bdf1c0c1df0008bd5139
Deploy Preview https://deploy-preview-1192--react-data-table-component.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JacksonSamuel42 commented 8 months ago

the pr of problem is #1156

jbetancur commented 8 months ago

Thank you for this PR, however, a major update was required as part of a refactor I have been working on and this was fixed in https://github.com/jbetancur/react-data-table-component/pull/1195