search

jbetancur / react-data-table-component

A responsive table library with built-in sorting, pagination, selection, expandable rows, and customizable styling.
https://react-data-table-component.netlify.app
Apache License 2.0
2.03k stars 409 forks source link

Fix Markdown Tables in Storybook (Netlify) #1204

Closed ADTC closed 7 months ago

ADTC commented 7 months ago

Fixes #1202.

See live demo here.

To fix the tables, we need to:

  1. Convert .storybook/main.ts to ES6 module (ESM).
  2. Downgrade remark-gfm to ^3.0.0 (this resolves to 3.0.1).

For more info, see this comment.

PS: Note btw that const prettierConfig was unused. That's why I took it out.

netlify[bot] commented 7 months ago

Deploy Preview for react-data-table-component ready!

Name Link
Latest commit af296f0b2b25207414dbcc787722102ff304e7e9
Latest deploy log https://app.netlify.com/sites/react-data-table-component/deploys/65a7d8ce78b03a0007a76f4c
Deploy Preview https://deploy-preview-1204--react-data-table-component.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jbetancur commented 7 months ago

Thank you for the PR and fix!