search

jbevain / cecil

Cecil is a library to inspect, modify and create .NET programs and libraries.
MIT License
2.71k stars 619 forks source link

Add RISCV64 TargetArchitecture #940

Closed clamp03 closed 4 months ago

clamp03 commented 5 months ago

It is for supporting RISCV64 in cecil Add RISCV64 to TargetArchitecture and update checks for pe64

Part of https://github.com/dotnet/runtime/issues/84834 cc @dotnet/samsung

clamp03 commented 5 months ago

@jbevain Could you please review this PR? It is for RISC-V architecture. Thank you.

clamp03 commented 5 months ago

I collected error message in CI. Is it caused by this PR? If then, could you please give any guide for me to fix the error? Thank you.

Testhost process for source(s) '/home/runner/work/cecil/cecil/symbols/pdb/Test/bin/Debug/netcoreapp3.1/Mono.Cecil.Pdb.Tests.dll' exited with error: You must install or update .NET to run this application.
Testhost process for source(s) '/home/runner/work/cecil/cecil/rocks/Test/bin/Debug/netcoreapp3.1/Mono.Cecil.Rocks.Tests.dll' exited with error: You must install or update .NET to run this application.
Testhost process for source(s) '/home/runner/work/cecil/cecil/symbols/mdb/Test/bin/Debug/netcoreapp3.1/Mono.Cecil.Mdb.Tests.dll' exited with error: You must install or update .NET to run this application.
Testhost process for source(s) '/home/runner/work/cecil/cecil/symbols/pdb/Test/bin/Debug/netcoreapp3.1/Mono.Cecil.Pdb.Tests.dll' exited with error: You must install or update .NET to run this application.
Error: Process completed with exit code 1.

@jbevain Could you please help? Thank you.

Numpsy commented 4 months ago

Is it caused by this PR? If then, could you please give any guide for me to fix the error?

Looks like the unit tests are trying to run on .NET Core 3.1, and the build agents don't have that installed by default any more?

clamp03 commented 4 months ago

My issue fixed by https://github.com/dotnet/runtime/pull/101038