search

jbevis / Get-Out-There

Personal Project for Turing School of Software & Design. Mod3 FEE
1 stars 0 forks source link

Jb welcome #54

Closed jbevis closed 7 years ago

jbevis commented 7 years ago

What's this PR do?

Very simple update to the app, I've added a separate component as a welcome screen, this is very basic right now, but will eventually hold links for different activities. Passing test file added as well.

Pre-Merge TODOs

Learning

Simply breaking out jsx into a new component to be more manageable as the app scales

Where should the reviewer start?

WelcomeCard.js

Any background context you want to provide?

In lieu of a landing page, this component will ultimately welcome the user and provide options for different activities.

What gif best describes this PR or how it makes you feel?

this one

Adamj1232 commented 7 years ago

Yo bigDawg! Looks great, nice touch with the font. Very smooth design...maybe lighten the opacity on your copyright...maybenot Good work!

jbevis commented 7 years ago

Thanks for the feedback guys, Adam, I agree that is popping a little too much.

@joshuajhun, @tman22, @rrgayhart for review.

ghost commented 7 years ago

This landing page looks good! The colors you chose for the text and button go well with the background image.