search

jbg / bitcoin-consensus

Rust bindings to libbitcoinconsensus
Apache License 2.0
5 stars 2 forks source link

Consider using `link-cplusplus` #5

Open thomaseizinger opened 3 years ago

thomaseizinger commented 3 years ago

At the moment, the build-script uses some heuristics to detect which C++ stdlib to link against.

There is actually a crate one can use to work around this problem: https://docs.rs/link-cplusplus

Would you accept a PR that removes these heuristics? We don't have any tests in here so we don't actually need to depend on link-cplusplus but I guess we should document that end-users will need to include it in their dependency tree.

jbg commented 3 years ago

Yes, I'd accept such a PR for sure.