jbhoot / pin-unpin-tab

Firefox add-on to pin or unpin current tab in more efficient ways.
https://addons.mozilla.org/en-US/firefox/addon/pinunpin-tab/
38 stars 2 forks source link

Clicking on HTML `select` element invokes long-click #19

Closed jbhoot closed 3 years ago

jbhoot commented 3 years ago

This behaviour is consistent. Examples:

Custom dropdown not made out of select elements don't have this problem. For example, dropdowns in Google Sheets.

It seems that mouseup is not triggered after a select element is clicked. I need to inspect further.

jbhoot commented 3 years ago

Firefox 89.0.2 on Linux generates mouseup when clicking on select.

This issue seems to be confined to macOS.

What about Windows?

jbhoot commented 3 years ago

The implemented fix does not track long-click when the clicked element is <select>.

jbhoot commented 3 years ago

With v4.2, the add-on does not track long-click on interactive elements or like a button, link, dropdown, etc., or elements with interactive roles like [role='button'], etc., fixing this issue.