jbhopkins / bioxtasraw

BioXTAS RAW is a GUI based, free, open-source Python program for reduction and analysis of small-angle solution scattering (SAS) data.
https://bioxtas-raw.readthedocs.io/en/latest/
GNU General Public License v3.0
10 stars 4 forks source link

Incorrect unit labels in IFT and GNOM windows #1

Closed rgillilan closed 1 year ago

rgillilan commented 2 years ago

When q units are changed from A-1 to nm-1 in the Radial Averaging panel, the old units of (A) still appear in the column labels of both the BIFT and GNOM windows. In other places, I think unit labels have simply been removed elsewhere, so that's a quick fix to avoid confusion. Longer term, probably plots should have unit labels.

jbhopkins commented 2 years ago

I would be in favor of removing unit labels, but not in favor of adding them everyone in a dynamic fashion. There's really no guarantee that people will work in the units set by the radial averaging panel (unless you're using RAW to reduce data I don't think anyone looks at that panel), and RAW attempts to be unit agnostic, generally. People could even be working with two datasets in different units.

rgillilan commented 2 years ago

I agree. If people want to use snapshots of panels in publications, they'll have to be sure to manually label or mention units. So leaving the labels out makes the most sense to actually avoid confusion.

On Sep 18, 2022, at 9:41 AM, jbhopkins @.**@.>> wrote:

I would be in favor of removing unit labels, but not in favor of adding them everyone in a dynamic fashion. There's really no guarantee that people will work in the units set by the radial averaging panel (unless you're using RAW to reduce data I don't think anyone looks at that panel), and RAW attempts to be unit agnostic, generally. People could even be working with two datasets in different units.

— Reply to this email directly, view it on GitHubhttps://github.com/jbhopkins/bioxtasraw/issues/1#issuecomment-1250311457, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AW55D5RXTLJEOV4ILLIQSRDV64LZBANCNFSM6AAAAAAQPNUK7M. You are receiving this because you authored the thread.Message ID: @.***>